Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide memo if it is an empty string Fixes #171 #195

Merged
merged 3 commits into from
Sep 11, 2023
Merged

hide memo if it is an empty string Fixes #171 #195

merged 3 commits into from
Sep 11, 2023

Conversation

KKA11010
Copy link
Collaborator

@KKA11010 KKA11010 commented Sep 10, 2023

When the app comes back to the foreground and the user has a token in its clipboard, a modal pops up showing the token and asking user to claim. This modal was showing the memo section even if there is no memo. Fixes #171

@KKA11010 KKA11010 added the UX User experience related label Sep 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (92d05a4) 14.92% compared to head (58b70bc) 14.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   14.92%   14.91%   -0.01%     
==========================================
  Files         140      140              
  Lines        4542     4545       +3     
  Branches     1233     1235       +2     
==========================================
  Hits          678      678              
- Misses       3780     3783       +3     
  Partials       84       84              
Files Changed Coverage Δ
src/components/ClipboardModal.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KKA11010 KKA11010 merged commit 7ccd4b0 into main Sep 11, 2023
5 checks passed
@KKA11010 KKA11010 deleted the memo branch September 11, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX User experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memo should not be visible if it is an empty string
2 participants