Compile JVM JNI native libaries using Zig, add Linux ARM #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
changed the title
JakeWharton
force-pushed
the
jw.zig.2024-12-18
branch
13 times, most recently
from
00f24a2 to
0fb9ec7
Compare
Zig's build system allows us to trivially cross-compile to different platforms and architectures than the host.
JakeWharton
force-pushed
the
jw.zig.2024-12-18
branch
from
0fb9ec7 to
b04aea9
Compare
squarejesse
approved these changes
Dec 19, 2024
squarejesse
reviewed
Dec 19, 2024
| License instead of this License. | ||
|
|
||
|
|
||
| "CLASSPATH" EXCEPTION TO THE GPL |
There was a problem hiding this comment.
This part’s important! And hiding
JakeWharton
commented
Dec 19, 2024
Comment on lines
+4
to
+6
| // The Windows builds create a .lib file in the lib/ directory which we don't need. | ||
| const deleteLib = b.addRemoveDirTree(b.getInstallPath(.prefix, "lib")); | ||
| b.getInstallStep().dependOn(&deleteLib.step); |
There was a problem hiding this comment.
We don't do Windows at the moment, but might in the future (#1360). It should be easier now, anyway.
|
Once it goes green I will change the required status checks and then merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1479. Closes #421.