Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only export component for React refresh #1298

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Only export component for React refresh #1298

wants to merge 9 commits into from
+239 −240

Conversation

JunichiSugiura
Copy link
Collaborator

@JunichiSugiura JunichiSugiura commented Jan 20, 2025 •
edited
Loading

This PR fixes all lint warnings such as

warning  Fast refresh only works when a file only exports components. Move your React context(s) to a separate file  react-refresh/only-export-components

@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui-next ✅ Ready (Inspect) Visit Preview Jan 21, 2025 0:01am

@JunichiSugiura JunichiSugiura changed the title Only export component for fast refresh Only export component for React refresh Jan 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 ui-next

⚠️ Visual Differences Detected

The following components have visual differences that need review:

icons--utility-chromium

icons--utility-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@JunichiSugiura JunichiSugiura force-pushed the chore/only-export-components branch from 4e4e7f4 to e0b8e25 Compare January 20, 2025 10:14
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 ui-next

⚠️ Visual Differences Detected

The following components have visual differences that need review:

icons--utility-chromium

icons--utility-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 ui-next

⚠️ Visual Differences Detected

The following components have visual differences that need review:

icons--utility-chromium

icons--utility-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 ui-next

⚠️ Visual Differences Detected

The following components have visual differences that need review:

icons--utility-chromium

icons--utility-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 ui-next

⚠️ Visual Differences Detected

The following components have visual differences that need review:

icons--utility-chromium

icons--utility-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 ui-next

⚠️ Visual Differences Detected

The following components have visual differences that need review:

icons--utility-chromium

icons--utility-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 ui-next

⚠️ Visual Differences Detected

The following components have visual differences that need review:

icons--utility-chromium

icons--utility-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 ui-next

⚠️ Visual Differences Detected

The following components have visual differences that need review:

icons--utility-chromium

icons--utility-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 ui-next

⚠️ Visual Differences Detected

The following components have visual differences that need review:

icons--utility-chromium

icons--utility-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

@JunichiSugiura JunichiSugiura marked this pull request as ready for review January 20, 2025 10:56
@JunichiSugiura JunichiSugiura requested review from tarrencev, bal7hazar and broody and removed request for tarrencev January 20, 2025 10:56
@JunichiSugiura JunichiSugiura force-pushed the chore/only-export-components branch from 894c270 to c78a270 Compare January 21, 2025 00:00
@github-actions GitHub Actions
Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 ui-next

⚠️ Visual Differences Detected

The following components have visual differences that need review:

breadcrumb--custom-separator-chromium

breadcrumb--custom-separator-chromium

badge--tab-chromium

badge--tab-chromium

accordion--default-chromium

accordion--default-chromium

icons--utility-chromium

icons--utility-chromium

breadcrumb--default-chromium

breadcrumb--default-chromium

toggle--default-chromium

toggle--default-chromium

⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bal7hazar bal7hazar Awaiting requested review from bal7hazar

@tarrencev tarrencev Awaiting requested review from tarrencev

@broody broody Awaiting requested review from broody

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JunichiSugiura