Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename @cartridge/ui-next to @cartridge/ui #1282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JunichiSugiura
Copy link
Collaborator

@JunichiSugiura JunichiSugiura commented Jan 17, 2025

Notice

  • This PR requires to reconfigure Vercel project accordingly before merging.

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui-next ❌ Failed (Inspect) Jan 20, 2025 5:59am

Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

3 similar comments
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

@JunichiSugiura JunichiSugiura marked this pull request as ready for review January 17, 2025 05:10
Copy link
Contributor

🎨 Visual Regression Test Results

✅ No visual changes detected

Copy link
Contributor

🎨 Visual Regression Test Results

❌ Visual differences detected

📦 ui

⚠️ Visual Differences Detected

The following components have visual differences that need review:

icons--utility-chromium

icons--utility-chromium

🔄 Snapshot Updates in PR

The following snapshots have been updated in this PR:

accordion--default-chromium

accordion--default-chromium

alert--alert-destructive-chromium

alert--alert-destructive-chromium

alert--default-chromium

alert--default-chromium

badge--default-chromium

badge--default-chromium

badge--muted-chromium

badge--muted-chromium

badge--primary-chromium

badge--primary-chromium

badge--tab-chromium

badge--tab-chromium

breadcrumb--custom-separator-chromium

breadcrumb--custom-separator-chromium

breadcrumb--default-chromium

breadcrumb--default-chromium

button--default-chromium

button--default-chromium

button--disabled-chromium

button--disabled-chromium

button--ghost-chromium

button--ghost-chromium

button--icon-chromium

button--icon-chromium

button--loading-chromium

button--loading-chromium

button--medium-chromium

button--medium-chromium

button--outline-chromium

button--outline-chromium

button--secondary-chromium

button--secondary-chromium

button--with-icon-chromium

button--with-icon-chromium

card--card-list-chromium

card--card-list-chromium

card--default-chromium

card--default-chromium

card--icon-header-chromium

card--icon-header-chromium

card--only-title-chromium

card--only-title-chromium

checkbox--default-chromium

checkbox--default-chromium

colors--accent-chromium

colors--accent-chromium

colors--card-chromium

colors--card-chromium

colors--default-chromium

colors--default-chromium

colors--destructive-chromium

colors--destructive-chromium

colors--muted-chromium

colors--muted-chromium

colors--others-chromium

colors--others-chromium

colors--popover-chromium

colors--popover-chromium

colors--primary-chromium

colors--primary-chromium

colors--secondary-chromium

colors--secondary-chromium

colors--tertiary-chromium

colors--tertiary-chromium

command--default-chromium

command--default-chromium

components-primitives-form--default-chromium

components-primitives-form--default-chromium

copyaddress--default-chromium

copyaddress--default-chromium

copyaddress--explicit-length-chromium

copyaddress--explicit-length-chromium

copyaddress--large-chromium

copyaddress--large-chromium

copyaddress--small-chromium

copyaddress--small-chromium

dialog--alert-dialog-chromium

dialog--alert-dialog-chromium

dialog--default-chromium

dialog--default-chromium

drawer--default-chromium

drawer--default-chromium

dropdown-menu--default-chromium

dropdown-menu--default-chromium

hover-card--default-chromium

hover-card--default-chromium

icons--brand-chromium

icons--brand-chromium

icons--brand-color-chromium

icons--brand-color-chromium

icons--directional-chromium

icons--directional-chromium

icons--duotone-chromium

icons--duotone-chromium

icons--state-chromium

icons--state-chromium

icons--utility-chromium

icons--utility-chromium

input--clear-chromium

input--clear-chromium

input--default-chromium

input--default-chromium

input--loading-chromium

input--loading-chromium

label--default-chromium

label--default-chromium

menubar--default-chromium

menubar--default-chromium

network--mainnet-chromium

network--mainnet-chromium

network--sepolia-chromium

network--sepolia-chromium

network--slot-chromium

network--slot-chromium

network--unknown-chromium

network--unknown-chromium

popover--default-chromium

popover--default-chromium

progress--default-chromium

progress--default-chromium

radio-group--default-chromium

radio-group--default-chromium

scroll-area--default-chromium

scroll-area--default-chromium

select--default-chromium

select--default-chromium

separator--default-chromium

separator--default-chromium

sheet--default-chromium

sheet--default-chromium

skeleton--default-chromium

skeleton--default-chromium

sonner--default-chromium

sonner--default-chromium

switch--default-chromium

switch--default-chromium

table--default-chromium

table--default-chromium

tabs--default-chromium

tabs--default-chromium

textarea--default-chromium

textarea--default-chromium

toast--default-chromium

toast--default-chromium

toggle--default-chromium

toggle--default-chromium

toggle-group--default-chromium

toggle-group--default-chromium

tooltip--default-chromium

tooltip--default-chromium


⚠️ Action Required: Please review the visual differences and:

  1. Update the snapshots locally if the changes are intended (scripts/update-storybook-snapshot.sh)
  2. Fix the components if the changes are unintended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant