Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Search icon would drift from input field #114

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Robadob
Copy link
Contributor

@Robadob Robadob commented Dec 8, 2023

Likewise, the search box appears to have a static size/position whilst visible (although the green magnifying glass does alot of walking about at widths >1200px).

This has been one of those frustrating bugs from the initial design that I haven't been able to pin down very well 😞

  • justify-content-end tells the form to justify it's contents (the input field) to the right hand side
  • position: relative makes position: absolute on children relative to the form, rather than the nav bar
  • top/right: update the offsets to match

This also requires the margin value used in #113 to be changed, which I've temporarily done inside 4276b7a.

@zkamvar If you let me know what you think I can finish this off and update NEWS, it's stable for me in Chrome now best I can tell.

Although, it would probably be cleaner to try and rebuild the whole nav to properly use Bootstrap's layout classes which would hopefully negate the need for #113 (but I try to avoid playing with CSS, it's awful imo).

One rule was behind media breakpoint when it shouldnt have been

Also think I misentered a value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant