Reuse search_params.clone() inside callbcak

Signed-off-by: carlosthe19916 <[email protected]>
carlosthe19916 · Sep 7, 2023 · ce43012 · ce43012
1 parent 7b3067d
commit ce43012
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/spog/ui/src/components/advisory/search.rs b/spog/ui/src/components/advisory/search.rs
@@ -96,13 +96,12 @@ pub fn advisory_search(props: &AdvisorySearchProperties) -> Html {
     total.set(state.data().and_then(|d| d.total));
 
     let onsort = {
-        let search_params_state = search_params.clone();
         use_callback(
             move |sort_by: (String, bool), search_params| {
                 if let SearchMode::Simple(simple) = &**search_params {
                     let mut simple = simple.clone();
                     simple.set_sort_by(sort_by);
-                    search_params_state.set(SearchMode::Simple(simple));
+                    search_params.set(SearchMode::Simple(simple));
                 };
             },
             search_params.clone(),

diff --git a/spog/ui/src/components/sbom/search.rs b/spog/ui/src/components/sbom/search.rs
@@ -104,13 +104,12 @@ pub fn sbom_search(props: &SbomSearchProperties) -> Html {
     total.set(state.data().and_then(|d| d.total));
 
     let onsort = {
-        let search_params_state = search_params.clone();
         use_callback(
             move |sort_by: (String, bool), search_params| {
                 if let SearchMode::Simple(simple) = &**search_params {
                     let mut simple = simple.clone();
                     simple.set_sort_by(sort_by);
-                    search_params_state.set(SearchMode::Simple(simple));
+                    search_params.set(SearchMode::Simple(simple));
                 };
             },
             search_params.clone(),

diff --git a/spog/ui/src/pages/search.rs b/spog/ui/src/pages/search.rs
@@ -297,13 +297,12 @@ where
     let search = use_hook(search_params.clone(), pagination.clone(), callback);
 
     let onsort = {
-        let search_params_state = search_params.clone();
         use_callback(
             move |sort_by: (String, bool), search_params| {
                 if let SearchMode::Simple(simple) = &**search_params {
                     let mut simple = simple.clone();
                     simple.set_sort_by(sort_by);
-                    search_params_state.set(SearchMode::Simple(simple));
+                    search_params.set(SearchMode::Simple(simple));
                 };
             },
             search_params.clone(),