[ADP-3272] WIP: Rough sketch of UTxO handling simplification. #4451
Conversation
| -- transaction. | ||
| -> Set TxIn | ||
| -- ^ Defines the subset of UTxOs that may be spent in addition to any | ||
| -- UTxOs that are already spent by a transcation. |
There was a problem hiding this comment.
| -- UTxOs that are already spent by a transcation. | |
| -- UTxOs that are already spent by a transaction. |
jonathanknowles
force-pushed
the
jonathanknowles/adp-3272/simplify-utxo-handling
branch
from
5afc550
to
9052584
Compare
jonathanknowles
changed the title
| @@ -3588,7 +3593,7 @@ balanceTransaction | |||
|
|
|||
| pure $ Write.PartialTx | |||
| (Write.fromCardanoApiTx tx) | |||
| externalUTxO | |||
| mempty -- externalUTxO | |||
There was a problem hiding this comment.
To be deleted ^^^
| @@ -2386,10 +2386,10 @@ buildTransactionPure | |||
| (Left $ unsafeShelleyOnlyGetRewardXPub @s (getState wallet)) | |||
| txCtx | |||
| (Left preSelection) | |||
| let utxoAll = Write.fromWalletUTxO utxo | |||
| let utxoSpendable = Map.keysSet (unUTxO utxoAll) | |||
There was a problem hiding this comment.
In the case where there is no partial transaction available, we allow balanceTx to spend from the entire UTxO set.
jonathanknowles
changed the title
jonathanknowles
changed the title
There was a problem hiding this comment.
While neat, I believe keeping the "extra utxo" alongside the Tx whose inputs it resolves makes conseptual sense. So I'd be hesitent in going away from this.
For instance, we could imagine writing the following helper function:
addInput :: (TxIn, TxOut era) -> PartialTx era -> PartialTx era
addInput (inp, out) = -- add inp to tx, add (inp, out) to extraUTxOI agree the wallet-influenced notion of UTxO conflict (different value or address) ideally shouldn't exist in cardano-balance-tx, but perhaps there is another solution to it which may become more apparent in the future. I don't think it's a problem worth thinking too much about at the moment.
🏗️ This PR does not compile -- it's just a rough sketch of a potential simplification of
balanceTransaction.TODO:
Issue
ADP-3272