Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADP-3185] Export era-related types and functions from Cardano.Write.Era. #4450

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jonathanknowles
Copy link
Member

@jonathanknowles jonathanknowles commented Feb 14, 2024

Issue

ADP-3185

@jonathanknowles jonathanknowles self-assigned this Feb 14, 2024
@jonathanknowles jonathanknowles changed the title Add public module Cardano.Write.Era . [ADP-3185] Export era-related types and functions from Cardano.Write.Era . Feb 14, 2024
@jonathanknowles jonathanknowles changed the title [ADP-3185] Export era-related types and functions from Cardano.Write.Era . [ADP-3185] Export era-related types and functions from Cardano.Write.Era. Feb 14, 2024
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling, it'd be great to wrap this up and stop importing things from cardano-balance-tx:internal! But I'm confused on the tactics here as I
1] thought we were going for one big (but not that big really) public umbrella module for cardano-balance-tx
2] find the degrees of freedom in

  • what public module is RecentEra in
  • what internal module is RecentEra in

a bit overwhelming and perhaps overkill.

Although in the end, the place where we really want an umbrella module is the theorized cardano-write Cardano.Write as Write also containing re-exports and helpers for Tx construction...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants