feat: Reliable queuing in the cardano-backer #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iFergal
reviewed
Aug 6, 2024
iFergal
reviewed
Aug 12, 2024
iFergal
reviewed
Oct 16, 2024
Sotatek-Patrick-Vu
force-pushed
the
feat/DTIS-967
branch
from
205e7b8
to
41381ff
Compare
iFergal
reviewed
Oct 20, 2024
|
|
||
| valid_backer_seals = 0 | ||
| # Should check when create identifiers only | ||
| if ilk in (Ilks.icp, Ilks.rot): |
There was a problem hiding this comment.
Can you change the comment to: @TODO - Should allow other methods, and check that backer trait set most recently to Cardano, as the current comment is wrong.
src/backer/backering.py
Outdated
| @@ -376,13 +380,14 @@ def __next__(self): | |||
| class MailboxIterable: | |||
| TimeoutMBX = 30000000 | |||
|
|
|||
| def __init__(self, mbx, pre, topics, retry=5000, hab=None, ledger=None): | |||
| def __init__(self, mbx, pre, topics, retry=5000, hab=None, ledger=None, queue=None): | |||
There was a problem hiding this comment.
queue shouldn't default to None as we need it. Also, I think we can remove ledger completely, and just check if topic == "/receipt"
Sotatek-Patrick-Vu
force-pushed
the
feat/DTIS-967
branch
from
b3d49fc
to
75aefb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Change
Ticket