Feat: PoC Basic metadata #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudvenger
reviewed
Mar 14, 2024
Scarb.toml
Outdated
|
|
||
| [dependencies] | ||
| starknet = ">=2.6.0" | ||
| starknet = ">=2.6.2" |
There was a problem hiding this comment.
so we go in 2.6.2 ? not in 2.5.4 ?
cloudvenger
suggested changes
Mar 14, 2024
There was a problem hiding this comment.
Just remove the useless import.
As it's a PoC, it's good to me.
But, for next iteration, as MVP, we should :
- Create components to manage metatda and storage. (
certificate_tokensandcertificate_valuesshould be in this component and not in contract). - We should implement a version of ERC-721 Enumerable to manage the total_supply of the certificate collection
cloudvenger
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue in Carbonable/metadata ...