Move the language server into toolchain's busybox. #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
infrastructure
toolchain
utilities
zygoloid
approved these changes
Nov 1, 2024
|
|
||
| const std::unique_ptr<clang::clangd::Transport> transport_; | ||
| // content of files managed by the language client. | ||
| std::unordered_map<std::string, std::string> files_; |
There was a problem hiding this comment.
Looks like you removed the include of <unordered_map> but kept the map. Can that be fixed somehow? (Also we should include <memory> for unique_ptr.)
| clang::clangd::DocumentSymbolParams const& params, | ||
| clang::clangd::Callback<std::vector<clang::clangd::DocumentSymbol>> cb); | ||
| clang::clangd::Callback<std::vector<clang::clangd::DocumentSymbol>> cb) |
There was a problem hiding this comment.
Do we need to include <vector> for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the separate language server binary; I'm not sure we need to provide it. Instead,
carbon language-serveris added as a subcommand.Moves //language_server to //toolchain/language_server. Splits into a trivial language_server.h, and a substantive server.h. I wasn't sure about a better name, but wanted the split similar to check/check.h, lex/lex.h, etc. At the same time, the class is probably going to be a little big so not a good fit to through into just a cpp file.
This fixes some style issues with the language server class, but generally I'm trying to not address things here in order to keep it simpler.