-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set .python-version
to 3.10 for pyenv users
#4456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG -- Sorry, for some reason I'd thought someone else got this PR.
Sorry, I see the pre-commit issue. In .pre-commit-config.yml, around line 215, I'd suggest inserting an exception, basically: .github/pull_request_template.md|
+ .python-version|
compile_flags.txt| |
Head branch was pushed to by a user without write access
I just added the copyright text instead, guessing that works too? |
See the error -- Python's strict about file contents. |
This reverts commit 34ce08b.
Head branch was pushed to by a user without write access
Huh, weird... I guess
In any case, I've now implemented your suggestion. Sorry for taking up so much of your time on this! |
No problem, it's really not much time and I should've reviewed last week. FWIW, I wasn't actually looking at what should be supported. |
The contribution docs for macOS say to install Python 3.10:
carbon-lang/docs/project/contribution_tools.md
Lines 118 to 124 in 957599b
For people who are using pyenv instead of Homebrew Python, this PR adds a
.python-version
file to specify Python 3.10 for pyenv to use.However, I also see that later in the same document, the docs only say that Python >=3.9 is required:
carbon-lang/docs/project/contribution_tools.md
Line 162 in 957599b
So in that case, feel free to just close this PR. I also saw that #778 specifically moved Carbon away from pyenv, so if pyenv is discouraged in general, also feel free to just close this.