Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the manifest path by flag. #4439

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Pass the manifest path by flag. #4439

merged 1 commit into from
Oct 23, 2024

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Oct 23, 2024

This is just a cleanup to remove the hardcoded path, since it's not really necessary in context.

chandlerc
chandlerc approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much simpler!

@chandlerc chandlerc added this pull request to the merge queue Oct 23, 2024
Merged via the queue into carbon-language:trunk with commit 5038218 Oct 23, 2024
10 checks passed
@jonmeow jonmeow deleted the manifest-flag branch October 23, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerc chandlerc chandlerc approved these changes

@zygoloid zygoloid Awaiting requested review from zygoloid

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonmeow @chandlerc