Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of minor tweaks to get approx. 10-15% compile time #4245

Merged
merged 1 commit into from
Aug 23, 2024

Commits on Aug 23, 2024

  1. Collection of minor tweaks to get approx. 10-15% compile time

    Most of these are about enabling inlining, in a couple of cases moving
    code to a header and throughout switching to `CARBON_DCHECK`. The
    code size of `CARBON_CHECK` seems to make inliing quite unreliable. I'm
    going to think about whether there are ways to improve this, but
    a reasonably small number of these seem worth switching for now to get
    some compile time savings.
    
    Also moves VLOG out of the hot path which helps a bit as well.
    
    All combined, this net a bit over 10%, although it varies a bit exactly
    how much. We're now pretty consistently over 800k lines/second for check
    in the compilation benchmark for files >=4k lines, which makes me happy.
    That's remarkably close to our original target.
    
    Not really planning to keep optimizing here, just was glancing at the
    profile and many of these stood out to me and were easy to fix.
    chandlerc committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    1ed158b View commit details
    Browse the repository at this point in the history