Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rudimentry debug info metadata emission #4225

Merged
merged 12 commits into from
Aug 20, 2024
Merged

Add rudimentry debug info metadata emission #4225

merged 12 commits into from
Aug 20, 2024

Commits on Aug 16, 2024

  1. Add rudimentry debug info metadata emission 

    This adds just the debug info metadata for Compilation Units (the top
level container of debug info) - but without anything in them, LLVM
won't emit them at all, so while this is testable at the IR level, it
isn't observable at the object level until more debug info is added.
    @dwblaikie
    dwblaikie committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    a835f50 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. left-bind '*' in toolchain/lower/file_context.h 

    Co-authored-by: Carbon Infra Bot <[email protected]>
    @dwblaikie @CarbonInfraBot
    dwblaikie and CarbonInfraBot authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    58981cd View commit details
    Browse the repository at this point in the history

  2. Add missing braces 

    Co-authored-by: Carbon Infra Bot <[email protected]>
    @dwblaikie @CarbonInfraBot
    dwblaikie and CarbonInfraBot authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    391bb7d View commit details
    Browse the repository at this point in the history

  3. add argument name comments for clarity 

    Co-authored-by: Jon Ross-Perkins <[email protected]>
    @dwblaikie @jonmeow
    dwblaikie and jonmeow authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    613c888 View commit details
    Browse the repository at this point in the history

  4. Rename BuildCompileUnit to BuildDICompileUnit

    @dwblaikie
    dwblaikie committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b57a741 View commit details
    Browse the repository at this point in the history

  5. Make FileContext::BuildDICompileUnit a factory function 

    (also rename it, adding the 'DI' in the name to match the type and
member variable name)

This renders `include_debug_info_` unused, so remove it - we can rely on
the CU being non-null as the marker for debug info emission in future
patches/work.
    @dwblaikie
    dwblaikie committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2c6dbf6 View commit details
    Browse the repository at this point in the history

  6. Rename cu_file to compile_unit_file for clarity

    @dwblaikie
    dwblaikie committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5a9a820 View commit details
    Browse the repository at this point in the history

  7. clang-format

    @dwblaikie
    dwblaikie committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4e57de9 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Merge branch 'trunk' into debug_info_flag_and_compilation_unit

    @dwblaikie
    dwblaikie committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    1eeafe1 View commit details
    Browse the repository at this point in the history

  2. Update tests

    @dwblaikie
    dwblaikie committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    dd996bd View commit details
    Browse the repository at this point in the history

  3. Add test for driver flag compatibility error

    @dwblaikie
    dwblaikie committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    dd0098d View commit details
    Browse the repository at this point in the history

  4. Autoupdate tests

    @dwblaikie
    dwblaikie committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    84dd9fe View commit details
    Browse the repository at this point in the history