Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor library names into their own ID structure. #4219

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Factor library names into their own ID structure. #4219

merged 1 commit into from
Aug 16, 2024

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Aug 15, 2024

This supports distinguishing between unset, Default, and "incorrect but already diagnosed, do not use" for extern library logic.

@jonmeow jonmeow mentioned this pull request Aug 15, 2024
Merged
chandlerc
chandlerc approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@chandlerc chandlerc added this pull request to the merge queue Aug 16, 2024
Merged via the queue into carbon-language:trunk with commit 64204d9 Aug 16, 2024
9 checks passed
@jonmeow jonmeow deleted the library-name-id branch August 19, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerc chandlerc chandlerc approved these changes

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonmeow @chandlerc