Skip to content

Commit

Permalink
Drop macos-12 runners.
Browse files Browse the repository at this point in the history
  • Loading branch information
jonmeow committed Oct 16, 2024
1 parent 3c58fb7 commit 5da020e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
7 changes: 3 additions & 4 deletions .github/actions/build-setup-macos/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@ runs:
xcrun simctl delete all
sudo rm -rf ~/Library/Developer/CoreSimulator/Caches/*
# Install and cache LLVM 16 from Homebrew.
# TODO: We can potentially remove this and simplify things when the
# Homebrew version of LLVM updates to 16 here:
# https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md
# Install and cache LLVM 16 from Homebrew. Some runners may have LLVM 16,
# but this is reliable (including with libc++), and gives us testing at the
# minimum supported LLVM version.
- name: Cache Homebrew
id: cache-homebrew-macos
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,8 @@ jobs:
test:
strategy:
matrix:
# On PRs and in the merge queue test a recent version of each supported
# OS. On push (post-submit), also run on `macos-12` to get Intel macOS
# coverage.
runner:
${{ fromJSON(github.event_name != 'push' && '["ubuntu-22.04",
"macos-14"]' || '["ubuntu-22.04", "macos-14", "macos-12"]') }}
# Test a recent version of each supported OS.
runner: ['ubuntu-22.04', 'macos-14']
build_mode: [fastbuild, opt]
include:
# The clang-tidy config doesn't work on macos (missing `truncate`).
Expand Down

0 comments on commit 5da020e

Please sign in to comment.