Skip to content

Commit

Permalink
fix(multple): edited broken and incorrect links (#1359)
Browse files Browse the repository at this point in the history
* fix(multple): edited broken and incorrect links

* fix(multiple): removed unecessary cards and fixed some more links

* fix(multiple): overall url fix for carbondesignsystem elements pages

* fix(app-icons): fixed typo on design tab
  • Loading branch information
Dan-Pastrolin-IBM authored Jul 4, 2024
1 parent 9ca7707 commit 046454a
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 45 deletions.
19 changes: 3 additions & 16 deletions src/pages/2x-grid.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ within it.
<ResourceCard
subTitle="2x Grid in UI: The mini unit"
aspectRatio="2:1"
href="https://www.carbondesignsystem.com/guidelines/2x-grid/overview#mini-unit"
href="https://carbondesignsystem.com/elements/2x-grid/overview#mini-unit"
>


Expand Down Expand Up @@ -430,7 +430,7 @@ baseline grid to guide your content.
<ResourceCard
subTitle="IBM type scale"
aspectRatio="2:1"
href="/typography/type-specs-ui/#scales"
href="/typography/type-scale"
actionIcon="arrowRight"
>

Expand Down Expand Up @@ -507,24 +507,11 @@ interfaces, please visit
<ResourceCard
subTitle="2x Grid in UI: Overview"
aspectRatio="2:1"
href="https://www.carbondesignsystem.com/guidelines/2x-grid/overview"
href="https://carbondesignsystem.com/elements/2x-grid/overview"
actionIcon="launch"
>


![carbon icon](../images/resource-cards/carbon.png)

</ResourceCard>
</Column>
<Column colMd={4} colLg={4} noGutterSm>
<ResourceCard
subTitle="2x Grid in UI: Implementation"
aspectRatio="2:1"
actionIcon="launch"
href="https://www.carbondesignsystem.com/guidelines/2x-grid/implementation"
>


![carbon icon](../images/resource-cards/carbon.png)

</ResourceCard>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/animation/overview.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ complex, ambient loop to feature brand film.
<Column colMd={4} colLg={4} noGutterSm>
<ResourceCard
subTitle="Motion in UI"
href="https://www.carbondesignsystem.com/guidelines/motion/overview"
href="https://www.carbondesignsystem.com/elements/motion/overview"
>

![carbon Icon](../../images/resource-cards/carbon.png)
Expand Down
2 changes: 1 addition & 1 deletion src/pages/color.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ are used sparingly and purposefully.
<ResourceCard
subTitle="Color in UI"
aspectRatio="2:1"
href="https://www.carbondesignsystem.com/guidelines/color/overview"
href="https://www.carbondesignsystem.com/elements/color/overview"
>

![CarbonIcon](../images/resource-cards/carbon.png)
Expand Down
5 changes: 1 addition & 4 deletions src/pages/data-visualization/design/basics.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ elements and make changes in the data set or on the environment explicit, clear
and unambiguous. Consider the entrance and exit motions to enhance the visual
hierarchy of elements, orientation of axes and the data displayed. Be careful
not to communicate contradicting information with different transitions.
[Learn more on Carbon](https://www.carbondesignsystem.com/guidelines/motion/overview).
[Learn more on Carbon](https://www.carbondesignsystem.com/elements/motion/overview).

</Column>
</Row>
Expand All @@ -333,6 +333,3 @@ not to communicate contradicting information with different transitions.

</DoDont>
</DoDontRow>



2 changes: 1 addition & 1 deletion src/pages/iconography/app-icons/design.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ of the app with more simplicity and abstraction. These icons should focus on the
bigger concepts of the product or service, such as scale, transaction,
integration and so on.  Functionally, fill app icons work best in situations
where you need to call attention to the app with more visual weight or a larger
color field, as opposed to the light, linear form of fill app icons.
color field, as opposed to the light, linear form of stroke app icons.

<ArtDirection>

Expand Down
4 changes: 2 additions & 2 deletions src/pages/iconography/ui-icons/contribute.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ As visual symbols, IBM user interface icons represent ideas, objects or actions.

Don’t see the icon you need in the library? Make your own! Follow these guidelines to ensure visual consistency and proper formatting.

- All icons should be unique and not redundant with any existing icons in the system. Search the [library](https://www.carbondesignsystem.com/guidelines/icons/library) for the keyword(s) associated with your proposed new icon to ensure that it is not already represented.
- All icons should be unique and not redundant with any existing icons in the system. Search the [library](https://www.carbondesignsystem.com/elements/icons/library) for the keyword(s) associated with your proposed new icon to ensure that it is not already represented.
- All icons should adhere to the [IBM Design Language](/iconography/ui-icons/design) visual style.
- All icons should comply with IBM [accessibility standards](https://www.carbondesignsystem.com/guidelines/accessibility/overview).
- All icons should be usable across all supported platforms and devices.
Expand Down Expand Up @@ -78,7 +78,7 @@ Does your icon have potential for other products at IBM? If so, please consider

### Getting started

Before submitting artwork, first review our [icons library](https://www.carbondesignsystem.com/guidelines/icons/library/) or download the [Carbon icon master .ai file](https://github.com/carbon-design-system/carbon/tree/master/packages/icons/master) to check your design for duplication against existing icons.
Before submitting artwork, first review our [icons library](https://www.carbondesignsystem.com/elements/icons/library) or download the [Carbon icon master .ai file](https://github.com/carbon-design-system/carbon/tree/master/packages/icons/master) to check your design for duplication against existing icons.

### Approval process

Expand Down
8 changes: 4 additions & 4 deletions src/pages/layout/tips-and-techniques.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ rhythm emerges.

#### 2x Grid

[The 2x Grid](/elements/2x-grid) is the scaffolding on which IBM designers
The [2x Grid](/2x-grid) is the scaffolding on which IBM designers
create structural rhythm. It provides structural, proportional, and spatial
guidance for design within any media. Skillful use of it will yield harmonious
spatial relationships between canvas and content while expressing our distinct
Expand All @@ -68,7 +68,7 @@ point-of-view.
#### Sizing scale

In lieu of concrete vertical divisions, such as on a web page, the
[sizing scale](https://www.carbondesignsystem.com/guidelines/layout#sizing-scale)
[sizing scale](https://www.carbondesignsystem.com/elements/2x-grid/overview/#sizing-scale)
is helpful in establishing vertical rhythm. Like a type scale, the sizing scale
constrains the range of sizes to improve consistency and rhythm, while still
allowing a wide range of sizes.
Expand Down Expand Up @@ -153,7 +153,7 @@ Typographic hierarchy is the navigational system that renders complex
information accessible. Think of a book outline; the size, style, and position
of type not only informs what order it should be read, but also describes the
parent-child relationships of the content. Effective use of the
[type scale](https://www.ibm.com/design/language/elements/type-specs-ui), along
[type scale](/typography/type-scale), along
with an understanding of
[Gestalt principles](https://www.interaction-design.org/literature/topics/gestalt-principles),
will ensure your design can be easily navigated and understood.
Expand Down Expand Up @@ -181,7 +181,7 @@ Facilitating eye movement through the composition creates a more interesting
design. A focal point instantly attracts the eye to one area of the canvas.
Secondary and tertiary elements then draw the eye across the canvas, creating
more engagement between the viewer and the design. This is done best through
[asymmetric layouts](/elements/layout/tips-and-techniques/#master-asymmetry),
[asymmetric layouts](/layout/tips-and-techniques/#master-asymmetry),
where thoughtful relationships between elements make for a more visually
stimulating design. It's important to plan the movement of the eye in order to
guide the viewer to the intended outcome.
Expand Down
20 changes: 4 additions & 16 deletions src/pages/resources.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ the alternatives shown here.
<Column colMd={4} colLg={4} noGutterSm>
<ResourceCard
subTitle="Color in UI"
href="https://www.carbondesignsystem.com/guidelines/color/overview"
href="https://www.carbondesignsystem.com/elements/color/overview"
>

![carbon Icon](../images/resource-cards/carbon.png)
Expand Down Expand Up @@ -202,19 +202,7 @@ href="https://marijohannessen.github.io/color-contrast-checker/"
<ResourceCard
subTitle="2x Grid in UI: Overview"
aspectRatio="2:1"
href="https://www.carbondesignsystem.com/guidelines/2x-grid/overview"
>

![carbon icon](../images/resource-cards/carbon.png)

</ResourceCard>
</Column>

<Column colMd={4} colLg={4} noGutterSm>
<ResourceCard
subTitle="2x Grid in UI: Implementation"
aspectRatio="2:1"
href="https://www.carbondesignsystem.com/guidelines/2x-grid/implementation"
href="https://carbondesignsystem.com/elements/2x-grid/overview/"
>

![carbon icon](../images/resource-cards/carbon.png)
Expand All @@ -239,7 +227,7 @@ href="https://www.ibm.com/design/language/files/2x_video_grid.ai"
<ResourceCard
subTitle="2x Grid in UI: The mini unit"
aspectRatio="2:1"
href="https://www.carbondesignsystem.com/guidelines/2x-grid/basics#mini-unit"
href="https://carbondesignsystem.com/elements/2x-grid/overview#mini-unit"
>

![carbon icon](../images/resource-cards/carbon.png)
Expand Down Expand Up @@ -603,7 +591,7 @@ href="https://developer.apple.com/design/human-interface-guidelines/macos/icons-
<ResourceCard
subTitle="Motion in UI"
aspectRatio="2:1"
href="https://www.carbondesignsystem.com/guidelines/motion/overview"
href="https://www.carbondesignsystem.com/elements/motion/overview"
>

![carbon Icon](../images/resource-cards/carbon.png)
Expand Down

0 comments on commit 046454a

Please sign in to comment.