Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): center align ghost button icons #18076

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Nov 14, 2024

Closes #17082

this PR updates the ghost button icons to be center aligned

image

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 2628d47
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/673632da0c06a0000840bec7
😎 Deploy Preview https://deploy-preview-18076--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 2628d47
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/673632da4a4be40008ec6360
😎 Deploy Preview https://deploy-preview-18076--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 2628d47
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/673632dabcce110009ac41b0
😎 Deploy Preview https://deploy-preview-18076--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (ad23c63) to head (2628d47).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18076   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files         404      404           
  Lines       14117    14117           
  Branches     4434     4404   -30     
=======================================
  Hits        11597    11597           
+ Misses       2359     2358    -1     
- Partials      161      162    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Button text and icon is not aligned properly
4 participants