Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive for mobile #1331

Merged
merged 5 commits into from
Feb 8, 2022
Merged

Conversation

hatsu38
Copy link
Contributor

@hatsu38 hatsu38 commented Feb 6, 2022

Before

スクリーンショット 2022-02-06 16 50 06スクリーンショット 2022-02-06 16 49 58

After For mobile Design

スクリーンショット 2022-02-06 16 47 57スクリーンショット 2022-02-06 16 48 13

  • Integration tests (if applicable)

Closes #1287

@vercel
Copy link

vercel bot commented Feb 6, 2022

@hatsu38 is attempting to deploy a commit to the Carbon Team on Vercel.

A member of the Team first needs to authorize it.

@hatsu38 hatsu38 marked this pull request as ready for review February 6, 2022 08:11
@JoshPaulie
Copy link

Holy cow! Great job.

@vercel
Copy link

vercel bot commented Feb 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-app/carbon/Bs3NvFKeucixgYgqd3ZCTCuVmend
✅ Preview: https://carbon-git-fork-hatsu38-responsive-for-mobile-carbon-app.vercel.app

@@ -69,6 +69,7 @@ class Popout extends React.PureComponent {
border-radius: 3px;
margin-top: 10px;
font-size: 12px;
z-index: 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just make this z-index even higher? Like 999?

Copy link
Contributor

@mfix22 mfix22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing @hatsu38! Thank you so much 🙏

@mfix22 mfix22 merged commit 3da8262 into carbon-app:main Feb 8, 2022
@mfix22 mfix22 added the contributor Add user as a contributor label Feb 8, 2022
@repo-ranger
Copy link
Contributor

repo-ranger bot commented Feb 8, 2022

@all-contributors add @hatsu38 for code

1 similar comment
@mfix22
Copy link
Contributor

mfix22 commented Feb 8, 2022

@all-contributors add @hatsu38 for code

@hatsu38 hatsu38 deleted the responsive-for-mobile branch February 8, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor Add user as a contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web app is unusable on mobile
3 participants