Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct import from collections module for >=3.10 #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

talonmyburgh
Copy link

Versions <Python3.10 fetch modules: MutableSet, MutableSequence and MutableMap from collections. Version >=Python3.10 fetch these modules from collections.abc.

This pull request makes this check and imports appropriately depending on the Python version in use.

…ping from collections.abs and not collections as before
@o-smirnov
Copy link
Member

Hang on, we should have retired this repo, as it's been rolled into stimela... sorry about the confusion!

@talonmyburgh
Copy link
Author

Ah okay, no worries.
Does this mean that we then need stimela to be installed in every python environment using clickify_parameters?
eg:
I have venv dspec_venv for running my script that uses scabha.schema_utils and my cab that wraps that script specifies the path to that venv.
I then have venv stimela_venv from which I launch stimela jobs. Is the idea then to install stimela inside dspec_venv and not launch jobs from stimela_venv?

@o-smirnov
Copy link
Member

Ah okay, no worries. Does this mean that we then need stimela to be installed in every python environment using clickify_parameters?

Yes. We originally thought to maintain scabha separately to avoid the full stimela install, but quickly realized it wasn't with the effort because (a) synchronizing releases for two packages is a pain in the backside, and (b) the full stimela install isn't really that big anyway.

eg: I have venv dspec_venv for running my script that uses scabha.schema_utils and my cab that wraps that script specifies the path to that venv. I then have venv stimela_venv from which I launch stimela jobs. Is the idea then to install stimela inside dspec_venv and not launch jobs from stimela_venv?

No, you still launch from stimela_venv. What happens in your dspec_venv stays in your dspec_venv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants