Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding: LinkAce #1181

Merged
merged 10 commits into from
Nov 29, 2024
Merged

Adding: LinkAce #1181

merged 10 commits into from
Nov 29, 2024

Conversation

wojtishek
Copy link
Contributor

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter (If failling run the prettier: npm run formatter-write)
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

@githubsaturn
Copy link
Collaborator

Thanks!

@githubsaturn githubsaturn merged commit 8968575 into caprover:master Nov 29, 2024
1 check passed
@VictorioBerra
Copy link
Contributor

@wojtishek Can we not append -simple to LinkAce tags? I am unable to use LinkAce 2.x because of this. There is no 2.x-simple. Is there a reason we require this?

@wojtishek
Copy link
Contributor Author

wojtishek commented Jan 21, 2025

@wojtishek Can we not append -simple to LinkAce tags? I am unable to use LinkAce 2.x because of this. There is no 2.x-simple. Is there a reason we require this?

@VictorioBerra Looks like v2 is still beta, according to same push time for v2.0.0-beta4 and 2.x tags. Also last official Github release is v1.15.6 as you can see here: https://github.com/Kovah/LinkAce/releases

@VictorioBerra
Copy link
Contributor

@wojtishek ARe we unable to use Beta? Should we create a new template for LinkAce-Beta?

@wojtishek
Copy link
Contributor Author

@VictorioBerra better solution should be to create Linkace-simple and Linkace-advanced templates IMHO (https://www.linkace.org/docs/v1/setup/setup-with-docker/). I'm not Linkace developer, so not sure what type of deployment is beta version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants