fix: [#1615] Fixes problems related to parsing <html>, <head> and <body> using DOMParser #1617
Conversation
…dy> using DOMParser
…body> using DOMParser
| const newDocument = domParser.parseFromString(DOMParserSVG, 'image/svg+xml'); | ||
| expect(new XMLSerializer().serializeToString(newDocument).replace(/[\s]/gm, '')).toBe( | ||
| DOMParserSVG.replace(/[\s]/gm, '') | ||
| ); | ||
| }); | ||
|
|
There was a problem hiding this comment.
If you're planning on handling all the cases - then i suggest these as well:
export const DOMParserBODYSibling = '<body><example></example>Example Text</body><body></body>';
export const DOMParserBODYChildren = '<body><body></body><example></example>Example Text</body>';
it('recognises does not duplicate body when BODY is a child', () => {
const newDocument = domParser.parseFromString(DOMParserBODYChildren, 'text/html');
expect(newDocument.body.innerHTML).toBe('<example></example>Example Text');
});
it('recognises does not duplicate body when BODY is a sibling', () => {
const newDocument = domParser.parseFromString(DOMParserBODYSibling, 'text/html');
expect(newDocument.body.innerHTML).toBe('<example></example>Example Text');
});
There was a problem hiding this comment.
I have added the test cases, thank you! 🙂
This turned out to be a lot more complicated than what I first thought and I had to refactor quite a bit of the logic, but I have hopefully covered all cases reported and discovered when reading the spec and tested in the browser.
There was a problem hiding this comment.
It's awesome though that you managed to get this through - impressive work :)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -128,11 +138,13 @@ export default < | |||
| }, | |||
| col: { | |||
| className: 'HTMLTableColElement', | |||
| contentModel: HTMLElementConfigContentModelEnum.noDescendants | |||
| contentModel: HTMLElementConfigContentModelEnum.noDescendants, | |||
| permittedParents: ['colgroup'] | |||
| }, | |||
| colgroup: { | |||
| className: 'HTMLTableColElement', | |||
There was a problem hiding this comment.
The class name is the same as the previous?
There was a problem hiding this comment.
This is correct.
If you run the following code in the browser you will see that both are using the HTMLTableColElement class:
// Outputs "HTMLTableColElement"
console.log(document.createElement('col').constructor.name);
// Outputs "HTMLTableColElement"
console.log(document.createElement('colgroup').constructor.name);
…-thus-creates-it-twice
capricorn86
deleted the
1615-domparser-does-not-recognise-body-and-thus-creates-it-twice
branch
No description provided.