fix: [#1418] Fix Object.{entries,key,values} on Storage #1423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This fixes #1418.
L79-84
checks that if a property does not exist in proxy target it returnundefined
for the configuration of the property andObject.keys(window.sessionStorage, '<existent_property_key>')
returns{ configurable: true, /** truncated for brevity */ }
on the browser (Tested on MS Edge 124).happy-dom/packages/happy-dom/src/storage/StorageFactory.ts
Lines 78 to 92 in c29f36c
Changes
Object.{entries,keys,values}()
throwingTypeError
onStorage
by setting{ configurable: true }
for all existent property in theStorage