fix: [1406] Fixes issue with insertBefore and comment reference node #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capricorn86
approved these changes
May 6, 2024
There was a problem hiding this comment.
Thank you for your contribution @mdafanasev! 🌟
In case you are interested, i'm working on a fix that removes ElementUtility and refactors the code to simplify the logic to avoid these kind of bugs 🙂
https://github.com/capricorn86/happy-dom/pull/1359/files#diff-f84cace34f3e54afcf796c8ae3f1f853f7abeb0451a8d52e2213db8857ae58dcR127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1406.
I found that when the reference node is not an Element, such as a comment, the insertion correctly occurs in the
childNodesarray, but the target node is not removed fromchildNodes; it is only removed fromchildren. Therefore, I have added code that also removes the target node fromchildNodes.