Fix a bug in createTextNode when the data argument is a non-string

[odanado]

Close #1380

Run in Chrome:

Run in Safari:

Run in Firefox:

[odanado]

In TypeScript lib.dom.d.ts, the createTextNode argument is not optional.

I have changed the type and implementation to mimic browser behavior.

Safari	Firefox	Chrome

Could you help me determine whether this change is considered a 'bug fix' or a 'breaking change'?

[capricorn86]

I would consider this as a bug fix as it is very unlikely to affect a consumer, but of course it would be great if this fix could be added as part of a major release. I think it is fine for this case.

[odanado]

   FAIL  test/fetch/SyncFetch.test.ts > SyncFetch > send() > Updates cache after a failed revalidation with a "If-Modified-Since" request for a GET response with "Cache-Control" set to a "max-age".
  AssertionError: expected 'some text' to be 'some new text' // Object.is equality

I noticed that the CI tests failed after I submitted my pull request.
However, the failure appears to be related to a test that is not associated with the changes I've made. I suspect it might be a flaky test.
Could you please advise on how to proceed? Should I try rerunning the tests, or is there anything else you'd recommend?

[capricorn86]

Thank you for your contribution @odanado! ⭐

[capricorn86]

   FAIL  test/fetch/SyncFetch.test.ts > SyncFetch > send() > Updates cache after a failed revalidation with a "If-Modified-Since" request for a GET response with "Cache-Control" set to a "max-age".
  AssertionError: expected 'some text' to be 'some new text' // Object.is equality

I noticed that the CI tests failed after I submitted my pull request. However, the failure appears to be related to a test that is not associated with the changes I've made. I suspect it might be a flaky test. Could you please advise on how to proceed? Should I try rerunning the tests, or is there anything else you'd recommend?

It's a known problem that has to be fixed. It is related to a timing issue with the cache expire time for in Fetch.ts and SyncFetch.ts.