#1216@patch: Clone response body when cloning a response. #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprecioso
changed the title
…o task/1216-fix-response-clone
…eam when cloning a Response body
capricorn86
previously approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Thank you for your contribution @cprecioso! 🌟
The Fetch API was migrated to using ReadableStream instead of Stream.Readable. This caused some issues when I merged in the changes as the clone solution used ReadableStream.tee(), which requires the cloned streams to be consumed in parallel.
I added support for piping the underlying Node Stream, which solved the problem.
capricorn86
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1216
Simply clones the Response's body stream when cloning the response.