Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1173@patch: HTMLInputElement[type=submit] and HTMLButtonElement set form submitter on click #1174

Merged
merged 4 commits into from
Jan 15, 2024
Merged

#1173@patch: HTMLInputElement[type=submit] and HTMLButtonElement set form submitter on click #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b3f475
#1173@patch: HTMLInputElement[type=submit] and HTMLButtonElement set …
aaltepet Dec 4, 2023
43e73a7
Merge branch 'master' into fix-form-submitter
capricorn86 Jan 14, 2024
fb026d9
Merge branch 'master' into fix-form-submitter
capricorn86 Jan 15, 2024
61577a0
#1173@trivial: Adds unit test for submitter to HTMLInputElement.
capricorn86 Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/happy-dom/src/nodes/html-button-element/HTMLButtonElement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ export default class HTMLButtonElement extends HTMLElement implements IHTMLButto
const form = <IHTMLFormElement>this[PropertySymbol.formNode];
switch (this.type) {
case 'submit':
form.requestSubmit();
form.requestSubmit(this);
break;
case 'reset':
form.reset();
Expand Down
2 changes: 1 addition & 1 deletion packages/happy-dom/src/nodes/html-input-element/HTMLInputElement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,7 +1301,7 @@ export default class HTMLInputElement extends HTMLElement implements IHTMLInputE
} else if (inputType === 'submit') {
const form = <IHTMLFormElement>this[PropertySymbol.formNode];
if (form) {
form.requestSubmit();
form.requestSubmit(this);
}
} else if (inputType === 'reset' && this[PropertySymbol.isConnected]) {
const form = <IHTMLFormElement>this[PropertySymbol.formNode];
Expand Down
8 changes: 7 additions & 1 deletion packages/happy-dom/test/nodes/html-button-element/HTMLButtonElement.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import Window from '../../../src/window/Window.js';
import Document from '../../../src/nodes/document/Document.js';
import IHTMLButtonElement from '../../../src/nodes/html-button-element/IHTMLButtonElement.js';
import Event from '../../../src/event/Event.js';
import SubmitEvent from '../../../src/event/events/SubmitEvent';
import IHTMLElement from '../../../src/nodes/html-element/IHTMLElement.js';
import IHTMLFormElement from '../../../src/nodes/html-form-element/IHTMLFormElement.js';
import ValidityState from '../../../src/validity-state/ValidityState.js';
Expand Down Expand Up @@ -255,11 +256,16 @@ describe('HTMLButtonElement', () => {

document.body.appendChild(form);

form.addEventListener('submit', () => submitTriggeredCount++);
let submitter: IHTMLElement | null = null;
form.addEventListener('submit', (event) => {
submitTriggeredCount++;
submitter = (<SubmitEvent>event).submitter;
});

button.click();

expect(submitTriggeredCount).toBe(1);
expect(submitter).toBe(button);
});

it('Resets form if type is "reset" and is a "click" event.', () => {
Expand Down
8 changes: 7 additions & 1 deletion packages/happy-dom/test/nodes/html-input-element/HTMLInputElement.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import HTMLInputElementSelectionDirectionEnum from '../../../src/nodes/html-inpu
import ValidityState from '../../../src/validity-state/ValidityState.js';
import IHTMLFormElement from '../../../src/nodes/html-form-element/IHTMLFormElement.js';
import DOMExceptionNameEnum from '../../../src/exception/DOMExceptionNameEnum.js';
import SubmitEvent from '../../../src/event/events/SubmitEvent.js';
import { beforeEach, describe, it, expect } from 'vitest';

describe('HTMLInputElement', () => {
Expand Down Expand Up @@ -1206,11 +1207,16 @@ describe('HTMLInputElement', () => {

document.body.appendChild(form);

form.addEventListener('submit', () => submitTriggeredCount++);
let submitter: IHTMLInputElement | null = null;
form.addEventListener('submit', (event) => {
submitTriggeredCount++;
submitter = <IHTMLInputElement>(<SubmitEvent>event).submitter;
});

button.click();

expect(submitTriggeredCount).toBe(1);
expect(submitter).toBe(button);
});

it('Resets form if type is "reset" and is a "click" event.', () => {
Expand Down