Merge pull request #1275 from capricorn86/1274-error-in-v1350-with-ge…

…t-svg-path-g-tag fix: [#1274] Fixes problem with query selectors not finding SVG eleme…
capricorn86 · Feb 25, 2024 · 8182be6 · 8182be6
2 parents 0894067 + 1ff9de3
commit 8182be6
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/packages/happy-dom/src/query-selector/SelectorItem.ts b/packages/happy-dom/src/query-selector/SelectorItem.ts
@@ -65,7 +65,7 @@ export default class SelectorItem {
 
 		// Tag name match
 		if (this.tagName) {
-			if (this.tagName !== '*' && this.tagName !== element[PropertySymbol.tagName]) {
+			if (this.tagName !== '*' && this.tagName !== element[PropertySymbol.tagName].toUpperCase()) {
 				return null;
 			}
 			priorityWeight += 1;

diff --git a/packages/happy-dom/test/query-selector/QuerySelector.test.ts b/packages/happy-dom/test/query-selector/QuerySelector.test.ts
@@ -1143,6 +1143,27 @@ describe('QuerySelector', () => {
 			expect(element2 === div.children[0]).toBe(true);
 		});
 
+		it('Returns SVG elements', () => {
+			document.body.innerHTML = `<svg width="3955.829" height="880" viewBox="0 0 3955.829 880" xmlns="http://www.w3.org/2000/svg" id="id_svg_model">
+                <g id="svgGroup" stroke-linecap="round" fill-rule="evenodd" font-size="9pt" 
+                    stroke="#000" stroke-width="0.25mm" fill="none" style="stroke:#000;stroke-width:0.25mm;fill:none"
+                >
+                    <path d="M 0 0 L 0 880 L 1272.697 880 A 80 80 0 0 0 1350.647 817.996 L 1416.442 533.006 A 120 120 0 0 1 1533.367 440 L 1977.914 440 L 2422.462 440 A 120 120 0 0 1 2539.386 533.006 
+                        L 2605.182 817.996 A 80 80 0 0 0 2683.131 880 L 3955.829 880 L 3955.829 0" 
+                        vector-effect="non-scaling-stroke">
+                    </path>
+                </g>
+            </svg>`;
+
+			const svg = document.querySelector('svg');
+			const path = document.querySelector('path');
+
+			expect(svg?.constructor.name).toBe('SVGSVGElement');
+
+			// TODO: Should be SVGPathElement, but it is not supported yet
+			expect(path?.constructor.name).toBe('SVGElement');
+		});
+
 		it('Throws an error when providing an invalid selector', () => {
 			const div = document.createElement('div');
 			expect(() => div.querySelector('1')).toThrowError(