Add fallback for empty userId by using null in Firestore query

[cp-sneh-s]

Changelog

Added fallback for empty userId in Firestore query

Enhancements

• Improved Firestore query behavior by ensuring that an empty userId is replaced with "null" instead of causing potential issues in document retrieval.

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of user ID retrieval to prevent errors with blank user IDs.

[coderabbitai]

Walkthrough

The changes in the ApiUserService.kt file focus on improving the user data retrieval mechanism. The primary modification involves handling blank user IDs more gracefully during document retrieval. The getUser method now uses a null-safe approach to ensure that blank user IDs are converted to "null" before fetching the document. The saveUser method's profile image logic remains functionally the same, with a minor formatting adjustment.

Changes

File	Change Summary
data/src/main/java/com/canopas/yourspace/data/service/user/ApiUserService.kt	- Modified getUser method to handle blank user IDs by converting them to "null" - Slight formatting update in saveUser method's profile image assignment

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac43e50 and 833ab29.

📒 Files selected for processing (1)

• data/src/main/java/com/canopas/yourspace/data/service/user/ApiUserService.kt (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• data/src/main/java/com/canopas/yourspace/data/service/user/ApiUserService.kt

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6391d5e and ac43e50.

📒 Files selected for processing (1)

• data/src/main/java/com/canopas/yourspace/data/service/user/ApiUserService.kt (2 hunks)

🧰 Additional context used

🪛 GitHub Actions: Android Build

data/src/main/java/com/canopas/yourspace/data/service/user/ApiUserService.kt

[error] 111-111: Unexpected indentation (16) (should be 20)

🔇 Additional comments (1)

data/src/main/java/com/canopas/yourspace/data/service/user/ApiUserService.kt (1)

52-53: LGTM! Verify the "null" document handling.

The fallback to "null" document ID for blank userIds is implemented correctly and aligns with the PR objectives.

Let's verify how this "null" document is handled in other parts of the codebase:

✅ Verification successful

✅ "null" document ID handling is consistent across the codebase

The fallback to "null" document ID is systematically implemented across all services using the same pattern, ensuring consistent behavior for blank IDs in both user and space contexts.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for other references to the "null" document ID
rg -l '"null"' | grep -v "test" | while read -r file; do
  echo "=== $file ==="
  rg -A 3 '"null"' "$file"
done

Length of output: 5273