Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the app dependencies and plugins with latest version #161

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

cp-sneh-s
Copy link
Collaborator

@cp-sneh-s cp-sneh-s commented Jan 9, 2025

Changelog

  • Update the dependencies with their latest version
  • Update plugin with its latest version

Summary by CodeRabbit

  • Dependency Updates

    • Updated Android SDK compilation version to 35
    • Upgraded multiple Android and Firebase dependencies to their latest versions
    • Updated Dagger Hilt plugin and Android libraries to newer releases
  • Maintenance

    • Performed routine dependency maintenance to ensure compatibility and access to latest features

Copy link

coderabbitai bot commented Jan 9, 2025

Walkthrough

This pull request focuses on updating dependencies and build configuration in the project's Gradle files. The primary changes include incrementing the Android SDK compilation version to 35 and updating multiple dependencies to their latest versions. These updates span various libraries such as AndroidX Core, Lifecycle, Compose, Firebase, Google Play Services, Hilt, and other utility libraries. The modifications represent a routine maintenance effort to keep the project's dependencies current and compatible.

Changes

File Changes
app/build.gradle.kts - Upgraded compileSdk from 34 to 35
- Updated multiple dependencies to latest versions, including:
* AndroidX Core KTX
* Lifecycle runtime
* Activity Compose
* Navigation Compose
* Compose Foundation
* Firebase BOM
* Google Play Services Auth
* Lifecycle process
* Arch Core Testing
* Work Runtime KTX
* Hilt Android
* Maps Utils
* Places Library
build.gradle.kts - Updated Dagger Hilt Android plugin version from 2.50 to 2.51.1

Possibly related PRs

Suggested reviewers

  • cp-megh-l
  • kaushiksaliya

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa0a641 and 87751ae.

📒 Files selected for processing (1)
  • app/build.gradle.kts (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/build.gradle.kts
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87cf70d and fa0a641.

📒 Files selected for processing (3)
  • app/build.gradle.kts (5 hunks)
  • build.gradle.kts (1 hunks)
  • data/build.gradle.kts (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
🔇 Additional comments (6)
build.gradle.kts (1)

6-6: Verify Kotlin compatibility with Dagger Hilt 2.51.1

The Dagger Hilt plugin version has been updated to 2.51.1, but the Kotlin version remains at 1.9.0. Please ensure compatibility between these versions.

✅ Verification successful

Kotlin 1.9.0 is compatible with Dagger Hilt 2.51.1

The current setup shows proper version alignment across the project, with consistent Hilt implementation in both app and data modules. The Kotlin version 1.9.0 is fully supported by Dagger Hilt 2.51.1.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if Dagger Hilt 2.51.1 mentions any Kotlin version requirements
curl -s "https://github.com/google/dagger/releases/tag/dagger-2.51.1" | grep -i "kotlin"

Length of output: 86


Script:

#!/bin/bash
# Find Kotlin version declarations in build files
echo "=== Kotlin Version ==="
rg "kotlin|kotlinVersion" build.gradle.kts -A 2 -B 2

echo -e "\n=== Dagger Hilt Configuration ==="
# Look for Dagger/Hilt related configurations
rg "dagger|hilt" --type kotlin build.gradle.kts -A 3 -B 3

echo -e "\n=== Version Catalogs ==="
# Check version catalogs if they exist
fd "libs.versions.toml" --exec cat {}

Length of output: 1319


Script:

#!/bin/bash
# Check for Hilt dependencies in build files
echo "=== Hilt Dependencies ==="
rg "hilt.*implementation" --type kotlin

echo -e "\n=== Module Build Files ==="
# Look for build files in app and other modules
fd "build.gradle.kts$" --type f --exec echo "=== {} ===" \; --exec cat {}

Length of output: 11049

data/build.gradle.kts (3)

11-11: Verify Android SDK 35 compatibility

The compileSdk has been updated to 35, which is a very recent release. Please ensure:

  1. All dependencies are compatible with SDK 35
  2. The app's minimum SDK (23) is still supported with SDK 35

44-44: Review breaking changes in core-ktx 1.15.0

The update from core-ktx 1.13.1 to 1.15.0 is a significant version jump. Please review the changelog for any breaking changes.


60-62: Verify Firebase BOM compatibility

The Firebase BOM update to 33.7.0 and play-services-auth update to 21.3.0 should be verified for compatibility with other Firebase services in use.

✅ Verification successful

Firebase dependencies are properly configured

The Firebase BOM 33.7.0 is correctly implemented across modules, and all Firebase services are using the platform's managed versions. The Play Services Auth and Location versions (21.3.0) are compatible with this Firebase BOM version.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for Firebase service usage in the codebase
rg -l "firebase" --type kotlin

Length of output: 2038


Script:

#!/bin/bash
# Check all Firebase and Google Play Services dependencies in Gradle files
rg "implementation.*firebase.*" build.gradle.kts app/build.gradle.kts data/build.gradle.kts
rg "implementation.*play-services.*" build.gradle.kts app/build.gradle.kts data/build.gradle.kts

# Check for other potential Firebase service initializations
rg "FirebaseApp" --type kotlin
rg "FirebaseFirestore" --type kotlin
rg "FirebaseMessaging" --type kotlin

Length of output: 4624

app/build.gradle.kts (2)

132-135: Verify Compose dependencies compatibility

Please ensure all Compose dependencies are compatible with:

  1. The new compose-bom:2024.12.01
  2. The updated core-ktx:1.15.0
  3. The updated activity-compose:1.9.3

168-170: Verify Hilt configuration consistency

The Hilt version is consistently updated to 2.51.1 across all modules, which is good. Please ensure the hilt-work dependency at line 174 is compatible with this version.

app/build.gradle.kts Show resolved Hide resolved
@cp-sneh-s cp-sneh-s requested a review from cp-megh-l January 9, 2025 10:46
cp-megh-l
cp-megh-l previously approved these changes Jan 9, 2025
@cp-sneh-s cp-sneh-s merged commit 6391d5e into main Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants