[DPE-5206] Add DIGEST scheme ACL to znode created by zookeeper #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theoctober19th
requested review from
Batalex,
marcoppenheimer,
welpaolo,
deusebio and
zmraul
welpaolo
approved these changes
Aug 21, 2024
Batalex
requested changes
Aug 22, 2024
theoctober19th
commented
Aug 22, 2024
welpaolo
approved these changes
Aug 22, 2024
deusebio
approved these changes
Aug 26, 2024
| acls = kwargs["acls"] | ||
| assert len(acls) == 2 | ||
| assert len([acl for acl in acls if acl.perms == 31 and acl.id.scheme == "sasl"]) != 0 | ||
| assert len([acl for acl in acls if acl.perms == 31 and acl.id.scheme == "digest"]) != 0 |
There was a problem hiding this comment.
question what is the 31 magic number?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional ACL with "DIGEST" scheme to the znodes created by zookeeper. This is needed because Kyuubi uses DIGEST ACL to create / write znodes and is not able to access the znodes created by zookeeper otherwise.