Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds integration test #7

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Jul 16, 2024

Whereabouts depends on Multus, which means that the integration test is deploying Multus as well.

Depends-On: #8
Depends-On: canonical/k8s-test-harness#9
Depends-On: canonical/k8s-test-harness#10

@claudiubelu claudiubelu requested a review from a team as a code owner July 16, 2024 07:46
@claudiubelu claudiubelu force-pushed the adds-integration-test branch 2 times, most recently from 751ddf0 to a78acad Compare July 16, 2024 10:03
Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the k8s-test-harness now that we have it.

@claudiubelu
Copy link
Contributor Author

Please use the k8s-test-harness now that we have it.

done

Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a comment on having a generic approach for the Rocks->helm setup.

tests/integration/test_whereabouts.py Show resolved Hide resolved
Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@claudiubelu claudiubelu force-pushed the adds-integration-test branch 3 times, most recently from 96492fa to 852e9f2 Compare July 19, 2024 10:34
Whereabouts depends on Multus, which means that the integration
test is deploying Multus as well.
@bschimke95 bschimke95 merged commit ae9cc48 into canonical:main Jul 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants