Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WD-12036 Dev Rebrand /security/cc #14692

Open
wants to merge 4 commits into
base: feature-security-bubble
Choose a base branch
from
Open

WD-12036 Dev Rebrand /security/cc #14692

wants to merge 4 commits into from
+149 −99

Conversation

immortalcodes
Copy link
Member

@immortalcodes immortalcodes commented Jan 30, 2025 •
edited
Loading

Done

  • Rebrand /security/cc
  • Upgrade vanilla version

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes
  • Demo
  • Design
  • Copydoc

Issue / Card

Fixes # Wd-12036

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@immortalcodes immortalcodes changed the base branch from main to feature-security-bubble January 30, 2025 06:18
@kim-isaac
Copy link

kim-isaac commented Jan 30, 2025 •
edited by immortalcodes
Loading

hey @immortalcodes thanks for your work! It looks great and I have a few comments:

  • The overall page color theme is Paper(F3F3F3). It's currently set to Light(FFFFFF), so please update it accordingly.

  • From the hero section: we can remove 'Get Ubuntu Advantage' btn and follow the live page, since it's already have same url link in the body text.
    Screenshot 2025-01-30 at 11 14 09

@kim-isaac
Copy link

Looks great, TY @immortalcodes ! I'll add a +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Review: Code needed Review: Design +1 Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@immortalcodes @webteam-app @kim-isaac @muhammad-ali-pk