Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy update: /aws/fips #14675

Merged
merged 5 commits into from
Jan 30, 2025
Merged

copy update: /aws/fips #14675

merged 5 commits into from
Jan 30, 2025

Conversation

andesol
Copy link
Contributor

@andesol andesol commented Jan 23, 2025

@webteam-app
Copy link

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.32%. Comparing base (c4540a6) to head (3310663).
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14675   +/-   ##
=======================================
  Coverage   72.32%   72.32%           
=======================================
  Files         120      120           
  Lines        3404     3404           
  Branches     1172     1174    +2     
=======================================
  Hits         2462     2462           
  Misses        917      917           
  Partials       25       25           

@andesol andesol marked this pull request as ready for review January 28, 2025 10:13
@andesol
Copy link
Contributor Author

andesol commented Jan 28, 2025

@eliman11 (Not sure whether you can have a look at this, let me know if not)

This is the current layout for the cta block:

image

The requirement is to add two new links for the newest ubuntu LTS, one for ARM64, one for Graviton (see copy doc), while keeping the old links. Problem is: this doesn't seem to work with the space available in the current layout, where all the links are in one line.

This is my proposal to move the secondary links to a new line:

image

But it looks a bit off to me... Do you have any suggestion about how to handle this?

@eliman11
Copy link

eliman11 commented Jan 28, 2025

@andesol Thanks for flagging! I agree - we usually try to limit hero sections to just 3 CTAs. I've asked a question to the stakeholder on the copydoc to just have those first two CTAs since the other links are repeated further down the page. Will try to figure out a workaround if not.

@eliman11
Copy link

Just received feedback from the stakeholder - they're happy to only have the most recent LTS in the hero and deleting the other links. I'd suggest using the secondary button in that case like in the screenshot below. Thanks!
Screenshot 2025-01-28 at 15 56 27

Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andesol, a few minor comments:

templates/aws/fips.html Outdated Show resolved Hide resolved
templates/aws/fips.html Outdated Show resolved Hide resolved
templates/aws/fips.html Outdated Show resolved Hide resolved
templates/aws/fips.html Outdated Show resolved Hide resolved
@andesol
Copy link
Contributor Author

andesol commented Jan 29, 2025

@mtruj013 Thanks for your thorough review! I think I fixed it. Please have another look when you have time.

@andesol andesol requested a review from mtruj013 January 29, 2025 13:46
mtruj013
mtruj013 previously approved these changes Jan 30, 2025
Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andesol! LGTM, pending one minor change:

templates/aws/fips.html Outdated Show resolved Hide resolved
@andesol andesol merged commit fc69e8a into canonical:main Jan 30, 2025
16 checks passed
@andesol andesol deleted the copy-update-1 branch January 30, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants