-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy update: /aws/fips #14675
copy update: /aws/fips #14675
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14675 +/- ##
=======================================
Coverage 72.32% 72.32%
=======================================
Files 120 120
Lines 3404 3404
Branches 1172 1174 +2
=======================================
Hits 2462 2462
Misses 917 917
Partials 25 25 |
@eliman11 (Not sure whether you can have a look at this, let me know if not) This is the current layout for the cta block: The requirement is to add two new links for the newest ubuntu LTS, one for ARM64, one for Graviton (see copy doc), while keeping the old links. Problem is: this doesn't seem to work with the space available in the current layout, where all the links are in one line. This is my proposal to move the secondary links to a new line: But it looks a bit off to me... Do you have any suggestion about how to handle this? |
@andesol Thanks for flagging! I agree - we usually try to limit hero sections to just 3 CTAs. I've asked a question to the stakeholder on the copydoc to just have those first two CTAs since the other links are repeated further down the page. Will try to figure out a workaround if not. |
3cb5e69
to
7918ace
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andesol, a few minor comments:
@mtruj013 Thanks for your thorough review! I think I fixed it. Please have another look when you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andesol! LGTM, pending one minor change:
QA
Issue
https://warthogs.atlassian.net/browse/WD-18368