WD-7790 - uptade /telco/osm page #13421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://ubuntu-com-13421.demos.haus |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13421 +/- ##
=======================================
Coverage 74.41% 74.41%
=======================================
Files 107 107
Lines 2838 2838
Branches 946 946
=======================================
Hits 2112 2112
Misses 702 702
Partials 24 24 |
anthonydillon
requested changes
Jan 3, 2024
There was a problem hiding this comment.
@lizzochek good stuff. A few suggestions and comments in the code.
templates/telco/osm/index.html
Outdated
| @@ -85,7 +87,7 @@ <h2>Charmed OSM</h2> | |||
| <li class="p-list__item is-ticked">Predictable release cadence and upgrade path</li> | |||
| </ul> | |||
| <p> | |||
| <a href="https://charmed-osm.com/">Read more ›</a> | |||
| <a href="https://charmed-osm.com/">Read more about Charmed OSM ›</a> | |||
There was a problem hiding this comment.
Suggestion in the copy doc to remove this link as this site does not exist anymore.
There was a problem hiding this comment.
yes can leave off for now, PM can resubmit if they have a new link
Co-authored-by: Anthony Dillon <[email protected]>
Co-authored-by: Anthony Dillon <[email protected]>
Co-authored-by: Anthony Dillon <[email protected]>
|
@lizzochek - I left two comments in the copydoc of things to update, after that its +1 from me. Thanks so much! |
|
@Sophie-32 @anthonydillon updated |
anthonydillon
approved these changes
Jan 3, 2024
anthonydillon
added
Review: QA +1
Review: Code +1
and removed
Review: QA needed
Review: Code needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Update OSM page according to copy doc
QA
./run serveIssue / Card
WD-7790
Fixes #
Screenshots