Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare libs in metadata #578

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

Thanhphan1147
Copy link
Collaborator

@Thanhphan1147 Thanhphan1147 commented Nov 1, 2024

Need to wait for #577 to get merged.

Add charm libs declaration in charmcraft.yaml to support charmcraft fetch-libs. Also update some libs to latest patch.

Library Changes

some libs are updated to latest patch.

Checklist

@Thanhphan1147 Thanhphan1147 requested a review from a team as a code owner November 1, 2024 09:45
@Thanhphan1147 Thanhphan1147 marked this pull request as draft November 1, 2024 09:46
@Thanhphan1147
Copy link
Collaborator Author

putting this to draft while waiting for #577

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Test coverage for bebf8b9

Name                                    Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------
src/actions/__init__.py                     1      0      0      0   100%
src/actions/register_user.py               21      0      2      0   100%
src/admin_access_token.py                   9      0      0      0   100%
src/backup.py                             175      5     20      2    96%   353-354, 423-424, 480->482, 483
src/backup_observer.py                    134     16     12      0    89%   132-135, 140-143, 179-182, 211-214
src/charm.py                              284     20     68     11    91%   132->134, 137, 234, 238-239, 245-246, 267-268, 296, 303, 384-388, 391-392, 420-422, 442, 478-479
src/charm_state.py                        150      8     30      6    92%   271, 275, 296, 321, 327, 333, 337-338
src/charm_types.py                         34      0      0      0   100%
src/database_client.py                     57      1      8      4    92%   35, 47->exit, 69->exit, 88->98
src/database_observer.py                   39      0      4      1    98%   70->72
src/exceptions.py                           3      0      0      0   100%
src/media_observer.py                      41      4      2      1    88%   61-63, 82
src/mjolnir.py                             97      3     30      3    95%   82, 91->107, 112-116
src/observability.py                       14      0      0      0   100%
src/pebble.py                             201     27     46     13    84%   57->62, 176->exit, 187-191, 225-226, 246-247, 300->305, 308-309, 321-322, 324-325, 339-340, 357, 359, 361, 363, 365, 393, 445-450
src/redis_observer.py                      35      3      4      0    92%   62-65
src/s3_parameters.py                       22      0      4      0   100%
src/saml_observer.py                       31      0      4      0   100%
src/smtp_observer.py                       56      4     14      2    91%   82-86, 89, 108->113
src/synapse/__init__.py                     4      0      0      0   100%
src/synapse/admin.py                       19      2      2      0    90%   40-41
src/synapse/api.py                        175      3     20      3    97%   176, 229, 402
src/synapse/workload.py                   134      2     20      0    99%   405-406
src/synapse/workload_configuration.py     163     26     38     13    81%   85->exit, 89-90, 138-139, 168, 188-189, 221-222, 255, 264-265, 286-287, 306->311, 312, 330->332, 342-343, 359, 406->409, 433-434, 462, 470->472, 472->474, 479-480, 500->507, 510, 530-531
src/user.py                                23      0      2      0   100%
-----------------------------------------------------------------------------------
TOTAL                                    1922    124    330     59    92%

Static code analysis report

Working... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00
Run started:2024-11-01 09:46:45.795631

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 10945
  Total lines skipped (#nosec): 4
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant