Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: make the group configurable #13

Merged
merged 2 commits into from
May 6, 2024

Conversation

simondeziel
Copy link
Member

This is useful for non-GitHub hosted runners (like Canonical ones) where the running user isn't necessarily member of the adm group.

@simondeziel simondeziel marked this pull request as ready for review May 2, 2024 18:25
@addyess
Copy link

addyess commented May 2, 2024

@barrettj12 and @mr-cal

This is amazing. I can build on self-hosted ARM64 runners now which are in the lxd group but not in the adm group.

Amazing work from @simondeziel
🍰 ⭐ 👍🏻 💯

@simondeziel
Copy link
Member Author

The CI failures are addressed in #12 already so I'll happily rebase once that gets merged.

@tomponline
Copy link
Member

Ready for rebase thanks

@simondeziel
Copy link
Member Author

@tomponline thanks, rebase done.

@tomponline tomponline merged commit 7be523c into canonical:main May 6, 2024
5 checks passed
@simondeziel simondeziel deleted the configurable-group branch May 6, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants