Skip to content

Commit

Permalink
Switch to charmcraft stable (#99)
Browse files Browse the repository at this point in the history
  • Loading branch information
carlcsaposs-canonical authored Jan 28, 2025
1 parent acf01a8 commit 8ed300b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ jobs:
- name: Check libs
uses: canonical/charming-actions/[email protected]
with:
charmcraft-channel: latest/candidate # TODO: remove after charmcraft 3.3 stable release
credentials: "${{ secrets.CHARMHUB_TOKEN }}" # FIXME: current token will expire in 2023-07-04
github-token: "${{ secrets.GITHUB_TOKEN }}"

Expand All @@ -58,11 +57,10 @@ jobs:
path:
- .
- tests/integration/application-charm
name: Build charm
name: Build charm | ${{ matrix.path }}
uses: canonical/data-platform-workflows/.github/workflows/[email protected]
with:
path-to-charm-directory: ${{ matrix.path }}
charmcraft-snap-channel: latest/candidate # TODO: remove after charmcraft 3.3 stable release

integration-test:
strategy:
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,15 @@ jobs:
uses: ./.github/workflows/ci.yaml
secrets: inherit

release-to-charmhub:
name: Release to CharmHub
release:
name: Release charm
needs:
- ci-tests
uses: canonical/data-platform-workflows/.github/workflows/[email protected]
with:
charmcraft-snap-channel: latest/candidate # TODO: remove after charmcraft 3.3 stable release
channel: latest/edge
artifact-prefix: ${{ needs.ci-tests.outputs.artifact-prefix }}
secrets:
charmhub-token: ${{ secrets.CHARMHUB_TOKEN }}
permissions:
contents: write # Needed to create GitHub release
contents: write # Needed to create git tags

0 comments on commit 8ed300b

Please sign in to comment.