Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert change for table pagination text adjustment on small screen #1040

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Feb 8, 2024

Done

  • Table pagination description should shrink based on its container width and not screen width. This was implemented before but was removed from a previous commit. This PR added the code back which implements the aforementioned logic.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Go to TablePagination component in Storybook and inspect that the pagination description to show X out of Y before small screen breakpoint (~830px)

@webteam-app
Copy link

Demo starting at https://react-components-1040.demos.haus

@mas-who mas-who merged commit 432966b into canonical:main Feb 8, 2024
6 checks passed
Copy link

github-actions bot commented Feb 8, 2024

🎉 This PR is included in version 0.50.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants