Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix contextual menu story #1005

Merged
merged 1 commit into from
Jan 19, 2024
Merged

docs: fix contextual menu story #1005

merged 1 commit into from
Jan 19, 2024

Conversation

petermakowski
Copy link
Contributor

Done

  • docs: fix contextual menu story

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Make sure the contextual menu story is rendered correctly.

@webteam-app
Copy link

Demo starting at https://react-components-1005.demos.haus

edlerd
edlerd approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@edlerd edlerd merged commit a3e1608 into canonical:main Jan 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermakowski @webteam-app @edlerd