Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create default storage class in chart #3

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Create default storage class in chart #3

merged 2 commits into from
Feb 6, 2024

Conversation

addyess
Copy link

@addyess addyess commented Feb 1, 2024 •
edited
Loading

Adds to the chart the option to manage a storage class named csi-rawfile-default.

  • the name is adjustable with --set storageClass.name="different-name"
  • the storage class doesn't have to be the default storage class
    • --set storageClass.isDefault=false
  • One must choose to install this SC
    • --set storageClass.enabled=true

other options are settable via:

  • storageClass.reclaimPolicy
  • storageClass.volumeBindingMode

bschimke95
bschimke95 reviewed Feb 2, 2024
View reviewed changes
Copy link

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell.
Only a minor comment for understanding.

deploy/charts/rawfile-csi/values.yaml Show resolved Hide resolved
berkayoz
berkayoz reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. It could be nice if we added options to configure reclaimPolicy and volumeBindingMode so it can be overridden.

@addyess
Copy link
Author

addyess commented Feb 6, 2024

Overall LGTM. It could be nice if we added options to configure reclaimPolicy and volumeBindingMode so it can be overridden.

Gotcha! and Done

berkayoz
berkayoz approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addyess addyess merged commit 2c7bb5b into rockcraft Feb 6, 2024
3 checks passed
@addyess addyess deleted the KU-276-update-rawfile-localpv-chart-to-also-deploy-a-storage-class branch February 6, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschimke95 bschimke95 bschimke95 left review comments

@berkayoz berkayoz berkayoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addyess @berkayoz @bschimke95