Relate to keystone to get credentials for exporter

[samuelallan72]

Save these credentials to a clouds.yaml file,
so they can be used by openstack-exporter.

If keystone in your test environment uses https, you may need to manually set the ssl_ca config.

internal ticket: BSENG-2172

[chanchiwai-ray]

Small issues and some questions

[samuelallan72]

@chanchiwai-ray thanks for your review! I responded to your comments; please see latest commits. :)

[samuelallan72]

Thanks @jneo8 and @chanchiwai-ray , I responded to your comments.

[chanchiwai-ray]

But overall it looks good to me. I don't want to be picky right now and block the PR here

[chanchiwai-ray]

Thanks, overall looks good, I left a comment about snap_service.restart().

(optional and opinionated) Can we make the non-event function without the _ prefix? It just looks nicer to me, and make me easier to visually distinguish the event callbacks and normal functions

[samuelallan72]

Can we make the non-event function without the _ prefix? It just looks nicer to me, and make me easier to visually distinguish the event callbacks and normal functions

So ideally all the other methods should have the _ prefix too, as this is used as a convention to show that they are internal methods and shouldn't be called from outside the class.

[chanchiwai-ray]

Can we make the non-event function without the _ prefix? It just looks nicer to me, and make me easier to visually distinguish the event callbacks and normal functions

So ideally all the other methods should have the _ prefix too, as this is used as a convention to show that they are internal methods and shouldn't be called from outside the class.

Yes, I understand that, so it's optional

[chanchiwai-ray]

Thanks, LGTM.

Did some basic testing with keystone:

• installed with resource -> Blocked: missing keystone relation
• relate to keystone -> Active
• curl the endpoint -> Blocked: snap service is not running (after update-status) (note this is expected with only keystone)
• changing config ssl_ca render the clouds.yaml