Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loki workaround #139

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Remove loki workaround #139

merged 2 commits into from
Dec 3, 2024

Conversation

nsklikas
Copy link
Contributor

IAM-1229

Upstream problem appears to be fixed by canonical/loki-k8s-operator#453

@nsklikas nsklikas requested a review from a team as a code owner November 29, 2024 13:26
@natalian98
Copy link

It appears that there is no 5.20 lxd release anymore, so the tests are failing. Can we use latest/stable instead?

lxd-channel: 5.20/stable

natalian98
natalian98 previously approved these changes Nov 29, 2024
@pik4ez-canonical
Copy link
Contributor

It appears that there is no 5.20 lxd release anymore, so the tests are failing. Can we use latest/stable instead?

lxd-channel: 5.20/stable

I understand that setting latest/stable will remove some chores from our team. For example, when the release disappears from the upstream like in the mentioned case.

But doesn't it mean that with latest/stable, it could be possible for the OpenFGA charm consumers to accidentally get a new major LXD version, which might be non-compatible with the charm?

According to the LXD docs, current stable 5.x channels are 5.21/stable and 5.0/stable (claimed to be LTS). I would suggest one of these if there are no strong objections.

@nsklikas
Copy link
Contributor Author

nsklikas commented Dec 3, 2024

It appears that there is no 5.20 lxd release anymore, so the tests are failing. Can we use latest/stable instead?

lxd-channel: 5.20/stable

I understand that setting latest/stable will remove some chores from our team. For example, when the release disappears from the upstream like in the mentioned case.

But doesn't it mean that with latest/stable, it could be possible for the OpenFGA charm consumers to accidentally get a new major LXD version, which might be non-compatible with the charm?

According to the LXD docs, current stable 5.x channels are 5.21/stable and 5.0/stable (claimed to be LTS). I would suggest one of these if there are no strong objections.

Agreed, I updated the lxd version. BTW isn't it weird that a release just disappeared or am I stupid?

@nsklikas nsklikas enabled auto-merge December 3, 2024 10:25
Copy link
Contributor

@BarcoMasile BarcoMasile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@nsklikas nsklikas merged commit 3085555 into main Dec 3, 2024
3 checks passed
@nsklikas nsklikas deleted the IAM-1229 branch December 3, 2024 10:46
@pik4ez-canonical
Copy link
Contributor

pik4ez-canonical commented Dec 3, 2024

Agreed, I updated the lxd version. BTW isn't it weird that a release just disappeared or am I stupid?

I wouldn't expect something like that to happen. Asked the LXD team for comments.

UPD posting the LXD team answers for visibility:

5.21/stable is an LTS release supported for 5 years (or 10 under Ubuntu Pro), so it won't be removed anytime soon.

LXD 5.20/stable was a feature release and as per policy it is only supported until the next feature release. We only keep the feature release channels for the last 2 feature releases, so as LXD 6.2 has just been released, LXD 5.20 was closed. Going forward we wont be using per-feature release tracks to avoid users following them and not getting updates. Instead we are moving to using a per-series track, so 6/stable will contain each 6.x release and will then progress into the next 6.x.x LTS series.

For integration testing you should be using an LTS candidate channel ideally, such as 5.0/candidate, 5.21/candidate, or if you want to test against the latest feature release in a series then latest/candidate. So that regressions are detected before stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants