Changes v4.0.2 rock base to bare #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching to a bare-based image will reduce the overall image size and reduces attack surface area. Only v4.0.2 is switched to bare as it is significantly simpler to achieve. It does require ``coreutils`` and ``procps`` (readiness probe uses ``pgrep``). We can no longer use ensure_image_contains_paths to check if files exist in the rock images, since they are now bare-based. Instead, we can use ensure_image_contains_paths_bare, which checks the image layers instead. Because of this, we need sufficient permissions to check the ``/var/lib/docker`` folder. Adds an extra sanity check during the integration tests, making sure that there is no error reported in Pebble while starting the service.
claudiubelu
force-pushed
the
change-base-to-bare
branch
from
78cc3b4
to
4e18f71
Compare
maci3jka
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to a bare-based image will reduce the overall image size and reduces attack surface area.
Only v4.0.2 is switched to bare as it is significantly simpler to achieve. It does require
coreutilsandprocps(readiness probe usespgrep).We can no longer use ensure_image_contains_paths to check if files exist in the rock images, since they are now bare-based. Instead, we can use ensure_image_contains_paths_bare, which checks the image layers instead. Because of this, we need sufficient permissions to check the
/var/lib/dockerfolder.Adds an extra sanity check during the integration tests, making sure that there is no error reported in Pebble while starting the service.