-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rock goss checks on PRs #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucabello
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
mmkay,
PietroPasotti,
sed-i and
simskij
as code owners
November 22, 2024 14:01
sed-i
reviewed
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Rocks currently have no tests on PR, making it impossible to know if they're working (besides trying to pack them), which in turn prevents us from auto-merging them.
Solution
Use
noctua
andgoss
to:goss
in the pod, and copy thegoss.yaml
file into itgoss validate
inside itTesting Instructions
Get
noctua
(here, you canpip install
it from git) and this rock repo (or any rock repo, if you write thegoss.yaml
).cd <version> && rockcraft pack
noctua rock test <rock_file> --goss-file=../goss.yaml --one-shot