-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
Demo starting at https://microstack-run-128.demos.haus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked on an Iphone X screen and there was an ellipses in the command:
But this ellipses also happens on juju. @anthonydillon do you know if this is expected behaviour or if this is a bug?
fbaae03
to
70f7f2e
Compare
70f7f2e
to
59f9410
Compare
I see the same on my phone. Difficult to know really. Hiding any part of the command is bad. Maybe the command should wrap in small screens. Unless we can set the font size based on the |
+1, wrap the command line seems like a good option for small screens |
Thanks for the feedback @anthonydillon and @clagom, let me know when it's ready for a review again @minkyngkm (happy to pair if needed). I'll create an issue on jaas.ai too. |
Thank you @bethcollins92, @anthonydillon and @clagom 🙏🏻 . I have updated it. Hopefully it looks better! - demo For your reference, I updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @minkyngkm - good job!
Done
<pre>
and<code>
element with<div>
with styles_row-cli.scss
file in static/sass for stylesQA
./run serve
Issue / Card
Fixes #127
Screenshots