Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Remove horizontal scroll bar #128

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Conversation

minkyngkm
Copy link
Contributor

Done

  • Replaced the <pre> and <code> element with <div> with styles
  • Added _row-cli.scss file in static/sass for styles

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8039/
  • Run through the following QA steps
  • Please check if the code snippet's animation is working well and it's responsive according to screen size

Issue / Card

Fixes #127

Screenshots

image

@webteam-app
Copy link

Demo starting at https://microstack-run-128.demos.haus

Copy link
Contributor

@bethcollins92 bethcollins92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked on an Iphone X screen and there was an ellipses in the command:

Screenshot 2021-09-07 at 13 41 50

But this ellipses also happens on juju. @anthonydillon do you know if this is expected behaviour or if this is a bug?

Screenshot 2021-09-07 at 13 42 45

templates/index.html Outdated Show resolved Hide resolved
@minkyngkm minkyngkm force-pushed the 127-fix-scrolls branch 5 times, most recently from fbaae03 to 70f7f2e Compare September 7, 2021 13:21
@anthonydillon
Copy link
Contributor

I see the same on my phone. Difficult to know really. Hiding any part of the command is bad. Maybe the command should wrap in small screens. Unless we can set the font size based on the vw.

@clagom
Copy link

clagom commented Sep 8, 2021

+1, wrap the command line seems like a good option for small screens

@bethcollins92
Copy link
Contributor

bethcollins92 commented Sep 8, 2021

Thanks for the feedback @anthonydillon and @clagom, let me know when it's ready for a review again @minkyngkm (happy to pair if needed). I'll create an issue on jaas.ai too.

@minkyngkm
Copy link
Contributor Author

Thank you @bethcollins92, @anthonydillon and @clagom 🙏🏻 . I have updated it. Hopefully it looks better! - demo

For your reference, I updated the line-height of the command line from 1rem to 1.2rem in case of the second line appearing on small screens. Please let me know if it's okay Beth :)

Copy link
Contributor

@bethcollins92 bethcollins92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @minkyngkm - good job!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A horizontal scroll bar appears on smaller screens
5 participants