Update o11y config #146
Merged
Update o11y config #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElineMaaikedeWeerd
force-pushed
the
update_o11y_config
branch
from
b3464d3
to
17992a1
Compare
SK1Y101
approved these changes
Jan 5, 2024
| {% if group_names|intersect(['maas_region_controller', 'maas_rack_controller']) %} | ||
| maas_az: {{ maas_availability_zone | default('default') }} | ||
| maas_region: {{ 'True' if 'maas_region_controller' in group_names else 'False' }} | ||
| maas_rack: {{ 'True' if 'maas_rack_controller' in group_names else 'False' }} |
There was a problem hiding this comment.
Wouldn't this be the same as
maas_region: {{ 'maas_region_controller' in group_names }}
maas_rack: {{ 'maas_rack_controller' in group_names }}There was a problem hiding this comment.
Yes, I think so-- thanks! It's a copy of the old o11y agent template, so what I'll do is create a separate PR updating all templates after this is merged-- seems cleaner to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 new Grafana Agent configurations for snap and deb installs, including logic to apply the correct configuration depending on MAAS version and installation method chosen. It will also install a newer version of the Grafana Agent package for MAAS versions 3.5 and above
This will align Ansible playbooks o11y setup with the monitoring MAAS setup for upcoming MAAS 3.5