[DPE-5702] chore: Active Controllers alert set to == 0 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoppenheimer
force-pushed
the
chore/alerts
branch
from
be6f650
to
2ca73c9
Compare
marcoppenheimer
changed the title
deusebio
reviewed
Oct 11, 2024
deusebio
approved these changes
Oct 11, 2024
|
I was syncing with @marcoppenheimer that has been discussing with @acsgn and my understanding is that the current PR should already fix the concerns or issue raised by ManSol. @sbparke Could you confirm that canonical/zookeeper-operator#166 and #252 address your comments and that we can move forward with the merge, and finalize the release? |
|
LGTM! Interval changes would help with updating the views faster. |
marcoppenheimer
changed the base branch from
main
to
3/stable-dplibs-upgrade-v38
marcoppenheimer
changed the base branch from
3/stable-dplibs-upgrade-v38
to
main
|
I'm happy for these to be merged, also given that also ManSol provided their +1 and they don't have concern with this |
deusebio
changed the title
deusebio
changed the title
deusebio
changed the title
deusebio
pushed a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.