Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-2195] Add certificate_extra_sans config option #125

Merged
merged 2 commits into from
Aug 14, 2023
Merged

[DPE-2195] Add certificate_extra_sans config option #125

merged 2 commits into from
Aug 14, 2023

Conversation

zmraul
Copy link
Contributor

@zmraul zmraul commented Aug 12, 2023 •
edited
Loading

Adds config option to specify extra sans.

  • A new property on tls.py has been added that parses the contents of certificate_extra_sans.
  • Config option uses {unit} placeholder and replaces it with the unit number.

MISC

  • Removed peer_relation property from KafkaTLS, to use charm.peer_relation instead.

@zmraul zmraul marked this pull request as ready for review August 14, 2023 06:59
deusebio
deusebio approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

config.yaml Outdated Show resolved Hide resolved
@zmraul zmraul requested a review from deusebio August 14, 2023 07:55
marcoppenheimer
marcoppenheimer approved these changes Aug 14, 2023
View reviewed changes
src/tls.py Show resolved Hide resolved
@zmraul zmraul merged commit db48f56 into main Aug 14, 2023
11 checks passed
@zmraul zmraul deleted the feature/dpe-2195-extra-sans-config branch August 14, 2023 19:10
@zmraul zmraul mentioned this pull request Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoppenheimer marcoppenheimer marcoppenheimer approved these changes

@deusebio deusebio deusebio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmraul @deusebio @marcoppenheimer